Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Wrong singular pluralization in Error Group Detail Page #46549

Closed
beniwohli opened this issue Sep 25, 2019 · 2 comments · Fixed by #47618
Closed

[APM] Wrong singular pluralization in Error Group Detail Page #46549

beniwohli opened this issue Sep 25, 2019 · 2 comments · Fixed by #47618
Assignees
@smith
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@beniwohli
Copy link

beniwohli commented Sep 25, 2019 •
edited by sorenlouv
Loading

Kibana version: 8.0 master

Describe the bug:

On Error Group Detail page, the "View N occurrences in Discover" is not properly pluralized for N=1

Steps to reproduce:

  1. Create a new error, with only one occurrence
  2. Go to APM Error Group detail page for said error
  3. There is no step 3

Expected behavior:

"View 1 occurrence in Discover"

Screenshots (if relevant):

Suggested solution
Replace the following line:

kibana/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/index.tsx

Line 89 in eeac753

'View {occurrencesCount} occurrences in Discover',

with

'View {occurrencesCount} {occurrencesCount, plural, one {occurence} other {occurences}} in Discover.'
@beniwohli beniwohli added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM All issues that need APM UI Team support labels Sep 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@ffknob
Copy link
Contributor

ffknob commented Oct 1, 2019

My attempt in getting to know more about contributing to open source software...
#47077

@smith smith self-assigned this Oct 8, 2019
smith added a commit to smith/kibana that referenced this issue Oct 8, 2019
@smith
[APM] Correctly plurarlize view in discover link
39b1de6 
Fixes elastic#46549
@smith smith mentioned this issue Oct 8, 2019
Merged
smith added a commit that referenced this issue Oct 8, 2019
@smith
[APM] Correctly plurarlize view in discover link (#47618)
6e956e3 
Fixes #46549
smith added a commit to smith/kibana that referenced this issue Oct 10, 2019
@smith
[APM] Correctly plurarlize view in discover link (elastic#47618)
6138786 
Fixes elastic#46549
smith added a commit that referenced this issue Oct 10, 2019
@smith
[7.x] [APM] Correctly plurarlize view in discover link (#47618) (#47836)
67ce81b 
Fixes #46549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Correctly plurarlize view in discover link smith/kibana
5 participants
@smith @beniwohli @sorenlouv @elasticmachine @ffknob