Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps][File upload] Tracking issue for GeoJSON Upload Optimizations #46376

Closed
2 of 8 tasks
kindsun opened this issue Sep 23, 2019 · 2 comments · Fixed by #92620
Closed
2 of 8 tasks

[Maps][File upload] Tracking issue for GeoJSON Upload Optimizations #46376

kindsun opened this issue Sep 23, 2019 · 2 comments · Fixed by #92620
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:File Upload Meta

Comments

@kindsun
Copy link
Contributor

kindsun commented Sep 23, 2019

There are several ways we can improve the Maps app's ability to upload GeoJSON files, some on the Maps side, some on the File Upload side. Some of these should be deemed more critical than others and are noted as such. This is a tracking issue to cover them.

  • Fix issue on Maps side copying entire feature collection as part of layer descriptor (critical) ([Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances #46381)
  • Chunk file on parse to prevent blocking of thread (originally identified here) and browser freeze (critical) ([Maps][File upload] Parse geojson files in chunks to avoid thread blocking #46710)
  • If possible, consolidate common logic between chunking operation used for chunked json parsing and chunking used to send data to ES from Kibana File Upload
  • Cap preview at 100MB
  • Consider memory optimization that deletes chunks after each is processed (may or may not be possible as we still have to deliver it to be indexed following preview)
  • Increase File Upload limit and Chunk limit (size TBD) (Make configurable?)
  • Revise File Upload to allow consuming applications to subscribe to chunked delivery (nice to have)
  • Update Maps app to allow adding layers in chunks. This is currently blocked by not having an accurate indicator downstream from mapboxgl indicating when the first layer chunk has been completely added. Connect to File Upload chunked delivery (nice to have)
@kindsun kindsun added Meta [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:File Upload labels Sep 23, 2019
@kindsun kindsun self-assigned this Sep 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 14, 2019

Should verify if fixes and improvements resolve #45510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:File Upload Meta
Projects
None yet
3 participants