Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] timestamp visualization #45986

Closed
katrin-freihofner opened this issue Sep 18, 2019 · 10 comments · Fixed by #47042
Closed

[Logs UI] timestamp visualization #45986

katrin-freihofner opened this issue Sep 18, 2019 · 10 comments · Fixed by #47042
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@katrin-freihofner
Copy link
Contributor

The timestamp in the current logs UI takes up a lot of horizontal space. As the date is highly repetitive the idea is to move the date in a separate row.
Screenshot 2019-09-18 at 10 05 34

Additionally, I propose to have the date sticky in the table header.
3fa8e53074146b677a24e5ec74e54397

@katrin-freihofner katrin-freihofner added discuss Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@Titch990
Copy link
Contributor

Looks good to me. :-)

@tbragin
Copy link
Contributor

tbragin commented Sep 21, 2019

@katrin-freihofner +1 on this idea.

@sgrodzicki
Copy link

Another idea would be to get rid of sub-second precision as the data is already sorted chronologically.

@weltenwort
Copy link
Member

the data is already sorted chronologically

That is only true up to a precision of one millisecond. In larger setups there will be quite a few events per millisecond and the tendency is to go to nanosecond resolution as soon as the stack allows it.

@weltenwort
Copy link
Member

Just a thought: Currently the date format is based on Kibana's advanced settings. If they will be split into separate date and time elements they will have to use a different source for that format.

@afgomez
Copy link
Contributor

afgomez commented Sep 30, 2019

@weltenwort Do we happen to have data on how many people change that value? If there's a lot of people we can try to be smart about it and parse what value is in there.

For example with the default MMM D, YYYY @ HH:mm:ss.SSS value we could do something like:

  • Split the string into characters.
  • For each character:
    • if the character is not time formatting, add it to the date formatting, continue.
    • if the character is time formatting, add it and the rest of the string to the time formatting. End

Of course that is naive and it doesn't take into account certain scenarios, but it could be worth following that path

@jasonrhodes
Copy link
Member

My opinion on the date format question, FWIW: I think it would be nice to "gently respect" a user's date time format choice, but more from a Sep 5, 2019 vs 5 Sep, 2019 vs 2019 Sep 5 perspective more than exactly the format they've chosen in settings. What I mean is that I don't think we should just blindly pull that format in if it doesn't work for the UX case and in this case not all formats will, because they're too bulky/noisy. But if someone has chosen day month and we are showing month day, that seems annoying.

Boiling down a format setting like this sounds complicated and I don't want it to hold up this feature. For now, I might either try to read in the current Kibana locale setting from config (config.get('i18n.locale')) and use it with toLocaleDateString()

new Date().toLocaleDateString('en-US', { month: 'short', year: 'numeric', day: 'numeric' })
"Oct 1, 2019"

If that ends up being too much of a pain, then just new Date().toLocaleString() might be the most user-friendly option ... although different from what @katrin-freihofner shows in the mockups:

new Date().toLocaleDateString()
"10/1/2019"

@katrin-freihofner
Copy link
Contributor Author

Yes, that is a good point @jasonrhodes. I agree we should respect the date-time format choice a user made. The idea was more, whatever date format is, it should be the table header, while the time should be in the rows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants