Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualizations plugin 👉 NP-ready #44306

Closed
10 tasks done
streamich opened this issue Aug 28, 2019 · 1 comment · Fixed by #44644 or #47142
Closed
10 tasks done

visualizations plugin 👉 NP-ready #44306

streamich opened this issue Aug 28, 2019 · 1 comment · Fixed by #44644 or #47142
Assignees
@streamich
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@streamich
Copy link
Contributor

streamich commented Aug 28, 2019 •
edited
Loading

Setup NP-ready folder for visualizations plugin in core_plugins/visualizations/

  • visualizations plugin 👉 NP-ready.
    • Create core_plugins/visualizations/public/np_ready/ folder.
      • Move all files into np_ready folder.
    • kibana.json manifest
    • index.ts
    • plugin.ts
    • legacy.ts
    • mocks.ts
    • Pass in legacy dependencies through __LEGACY object.
    • Implement .types.registerVisualization() instead of .types.VisTypesRegistryProvider.register() in setup contract.

Parent issue: #44121
@streamich streamich added 2sp Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Aug 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich streamich mentioned this issue Aug 28, 2019
Closed
13 tasks
@sainthkh sainthkh mentioned this issue Sep 3, 2019
Merged
9 tasks
@lukeelmers lukeelmers mentioned this issue Sep 4, 2019
Merged
@streamich streamich self-assigned this Oct 2, 2019
@streamich streamich mentioned this issue Oct 2, 2019
Merged
@streamich streamich reopened this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamich streamich

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Visualizations Plugin -> New Platform Ready sainthkh/kibana
visualizations 👉 NP-ready
2 participants
@streamich @elasticmachine