Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR] Move Show/Hide indices toggle link to outside of list #44036

Closed
jen-huang opened this issue Aug 26, 2019 · 4 comments · Fixed by #57163
Closed

[SR] Move Show/Hide indices toggle link to outside of list #44036

jen-huang opened this issue Aug 26, 2019 · 4 comments · Fixed by #57163
Assignees
@cuff-links
Labels
enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Aug 26, 2019 •
edited
Loading

In Snapshot and Restore, when there is a list of indices, the show/hide all indices toggle link is displayed as part of the unordered list (<li> item):

Screen Shot 2019-08-22 at 15 04 52

We should move this to outside the unordered list:

Screen Shot 2019-08-22 at 15 36 58

This UI appears in the following places:
image

We should also update the logic in all these places to be more readable, see #43390 (comment) for suggestion.

Originally posted by @sebelga in #43390 (comment)
@jen-huang jen-huang added enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Aug 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@jen-huang jen-huang mentioned this issue Aug 26, 2019
Merged
@deXetrous
Copy link

Hi @jen-huang , Can I work on this issue if that's fine?

@jen-huang
Copy link
Contributor Author

@deXetrous Sure thing, this isn't being worked on by anyone at the moment. Feel free to ping me in this issue with any questions and I'm also happy to review your PR. Thank you!!

@cuff-links cuff-links self-assigned this Feb 8, 2020
@cuff-links
Copy link
Contributor

I will grab this one.

@cuff-links cuff-links mentioned this issue Feb 8, 2020
Merged
@cjcenizal cjcenizal added good first issue low hanging fruit and removed low hanging fruit labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuff-links cuff-links

Labels
enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved all of the show/hide toggles outside of ordered lists. cuff-links/kibana
5 participants
@cjcenizal @cuff-links @jen-huang @elasticmachine @deXetrous