Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] TopNavMenu \ SearchBar API #42350

Closed
lizozom opened this issue Jul 31, 2019 · 3 comments
Closed

[DISCUSS] TopNavMenu \ SearchBar API #42350

lizozom opened this issue Jul 31, 2019 · 3 comments
Labels

Comments

@lizozom
Copy link
Contributor

lizozom commented Jul 31, 2019

SearchBar (and it's main consumer TopNavMenu) is a wrapper component for several other components:

  • QueryBar
  • QueryBarInput
  • EuiSuperDatePicker
  • FilterBar

Each of those requires a different set of arguments, however, they are all optional as SearchBar can be rendered without any one of them.

As a result, a user can't easily tell which arguments he must provide, to get the components he wants to render.

Search Bar Options

Search Bar

  • showSearchBar
  • showSearchBarInline - useful when you want to show timepicker inline with the menu items.

Filter Bar

Requires:

  • indexPatterns array
  • filters array
  • onFiltersUpdated function
  • showFilterBar

Query Bar

Query bar contains Query Bar Input and Timepicker.

  • onSubmit function to handle the results
  • showQueryBar

Query Bar \ Query Input

Requires:

  • indexPatterns array
  • query
  • appName
  • screenTitle
  • store
  • showQueryInput

Query Bar \ Date Picker

Optional (can render without any of these)

  • dateRangeFrom
  • dateRangeTo
  • isRefreshPaused
  • refreshInterval
  • onRefreshChange
  • showDatePicker -
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@alexh97 alexh97 closed this as completed Aug 15, 2019
@alexh97
Copy link

alexh97 commented Aug 15, 2019

This was closed accidentally due to a bad integration with a 3rd party app (Zube). My apologies.

@alexh97 alexh97 reopened this Aug 15, 2019
@lizozom
Copy link
Contributor Author

lizozom commented Dec 9, 2019

Handled as part of other on going @elastic/kibana-app-arch items like #50876

@lizozom lizozom closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants