Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Service should provide ability to proxy incoming requests #41960

Open
mshustov opened this issue Jul 25, 2019 · 9 comments
Open

Http Service should provide ability to proxy incoming requests #41960

mshustov opened this issue Jul 25, 2019 · 9 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Jul 25, 2019

Kibana provides own abstraction on top of the HTTP server, so dealing with KibanaRequest and KibanaResponse is not always makes sense because they were created to hide low-level details.
We already had a problem implementing #36907 when we needed access to all request headers. It looks like Http Service should support proxying requests out of the box, without exposing all request details.
Server should support request streaming to reduce memory footprint. Usage in Legacy: 1 2

Note: Legacy platform provides hapi h2o2 plugin to the plugins, but it doesn't mean we should do so.

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jul 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover
Copy link
Contributor

Note that the proxy endpoint in the Elasticsearch plugin is going away, but the Console one will still need to be supported.

@joshdover
Copy link
Contributor

It appears the proxy route in console does not require anything special other than support for streaming responses. I believe this may be possible after #50783 is merged. @afharo can you confirm?

@afharo
Copy link
Member

afharo commented Nov 18, 2019

Exactly, after #50783 is merged, we'll be able to support stream responses and larger payloads if required.

@afharo
Copy link
Member

afharo commented Nov 18, 2019

Also parse: false | 'gunzip' from the examples in the description.

@joshdover
Copy link
Contributor

Great, can you make that PR close this issue as well?

@afharo
Copy link
Member

afharo commented Nov 18, 2019

done!

@afharo
Copy link
Member

afharo commented Nov 28, 2019

Closing as #50783 has been merged (for some reason it didn't close automatically)

@mshustov
Copy link
Contributor Author

mshustov commented Jan 29, 2020

Reopened. Plugins proxying requests to elasticsearch will start failing when we merge #55670
related discussion https://github.com/elastic/kibana/pull/55690/files/5f76f38499821841a478d7fe9887f31090e14d85#r371806086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants