Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Update IDs on plugins migrated to the new platform #41931

Closed
lukeelmers opened this issue Jul 24, 2019 · 3 comments
Closed

[Breaking] Update IDs on plugins migrated to the new platform #41931

lukeelmers opened this issue Jul 24, 2019 · 3 comments
Assignees
Labels
Feature:NP Migration release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0

Comments

@lukeelmers
Copy link
Member

The ids contained in legacy package.json and index.js files of core_plugins are used for enabling/disabling plugins via kibana.yml config.

As part of the new platform migration efforts, we will be renaming/separating/combining some plugins into the structure outlined in the meta issue.

It would make sense to also update the IDs so that the names are consistent in yml config. This would technically be a breaking change, so this issue exists to track that all IDs have been changed in 8.0 and that the changes are properly documented for devs.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukeelmers
Copy link
Member Author

I did an audit of all app arch-owned plugins, and can confirm that no IDs need to be updated as these plugins are basically all new. (Other than checking to make sure naming is camelCase, but we already have a separate issue to track that)

When I created this issue originally, it was primarily with the legacy vis type plugins in mind, which were shuffled around a bit during migration.

@flash1293 I'll re-assign this to you & tag it for the app team. Feel free to close if you don't need it or are already tracking this elsewhere.

@lukeelmers lukeelmers added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:AppArch labels Mar 26, 2020
@flash1293
Copy link
Contributor

Handled via your latest PR @lukeelmers - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants