Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InfraUI] Allow users to filter by service.name #40424

Closed
roncohen opened this issue Jul 5, 2019 · 8 comments
Closed

[InfraUI] Allow users to filter by service.name #40424

roncohen opened this issue Jul 5, 2019 · 8 comments
Assignees
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@roncohen
Copy link
Contributor

roncohen commented Jul 5, 2019

We should make it possible to filter the InfraUI view to show hosts/pods/containers that are serving a specific APM service. You can imagine linking directly from the APM UI service list to the infra UI to see the an overview of the infrastructure that currently deals with this service.

I did a preliminary investigation and the good news is that it almost works. APM sends up data that includes service.name, host.name, container.id, and kubernetes.pod.id where available. There are 3 outstanding issues:

  1. APM sends host.hostname while infra expects host.name. By setting up an ingest pipeline that just copies the value for APM data i got it to work for the "host" page. I'll talk to ECS folks and APM folks separately to see what we do about it.

image

  1. When querying, we include host.name, container.name etc. in the composite grouping key. The APM documents do not have container.name while the metricbeat documents have container.name and so when we try to merge buckets it does not work because the keys don't match up. I wonder if there's a reason we use the names in additions to the IDs in the grouping or if it's a leftover from [InfraUI] Use container IDs instead of names for grouping, filtering and linking #26359

image

  1. Users will need to alter their source settings. We should consider adding apm-* or similar to the default
@roncohen roncohen added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jul 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@skh
Copy link
Contributor

skh commented Jul 5, 2019

I wonder if there's a reason we use the names in additions to the IDs in the grouping

IIRC we add them to the composite query to be able to use them for displaying the nodes. According to https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-composite-aggregation.html we should be able to set missing_bucket: true on the name fields and fall back to the id fields when needed.

@roncohen
Copy link
Contributor Author

will retest once #40804 is in

@roncohen
Copy link
Contributor Author

having Infra UI automatically query APM indices relates to ensure index patterns are defined in the same place: #41360

@jasonrhodes
Copy link
Member

This work relies on: elastic/apm-server#2502

@sgrodzicki
Copy link

As elastic/apm-server#2540 got merged, what are the next steps for this one?

@sgrodzicki
Copy link

@roncohen are there still any blockers?

@roncohen
Copy link
Contributor Author

closing as the code has been massaged to allow for this use case. Will open separate discussion on what to do with the index patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants