-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Fully migrate to new platform #38765
Comments
Pinging @elastic/kibana-stack-services |
Pinging @elastic/kibana-platform |
All plugins in the new platform run on all pages, meaning that all plugins have their
I would expect telemetry to be an optionalPlugin dependency for all plugins that integrate with it. That way an admin could disable it and be sure that telemetry code is not running at all without breaking any plugins. |
For usage collectors, I believe its a good idea to keep them in core as they are being used by almost every plugin to register collectors, plus it is used by monitoring to track kibana stats (for both telemetry and monitoring) and used by the kibana_stats beat that hits the It can be moved to telemetry but I'm not sure if we'd want that? |
Any reason it couldn't be an OSS plugin that both telemetry and monitoring could depend on? |
I have a PR open to move telemetry to OSS #45769 so we can put it there, but my concern is that we're gonna require telemetry as optional dep in every plugin so that might not be ideal + we'll have to change lots of code in lots of places. |
Places where
These are the places collectors are consumed. Collectors are registered in many plugins. Ideally I'd vote to keep it separate from telemetry as we can potentially use them in more places other than telemetry in addition to metric beat and monitoring. Even if the user disables telemetry, i believe we still want to have those collectors running as they do now as they might be consumed in other places. |
I've updated the description with a link to our collectorSet discussion in #46924 |
Pinging @elastic/pulse (Team:Pulse) |
Telemetry migrated to new platform #35403, but is using the old plugin system until the following features are introduced in the new platform:
Dealing with plugin Hacks.
Core exposing Banner
Replace legacy
collectorSet
with the NP metrics plugincollectorSets in the New Platform #46924
Dealing with management sections
SavedObjects server-side client Server saved objects client through request context #44143
CC @skaapgif
The text was updated successfully, but these errors were encountered: