Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Switch from "interval" to "fixed_interval" for aggs in datafeed configs #36758

Closed
droberts195 opened this issue May 21, 2019 · 3 comments · Fixed by #36759
Closed

[ML] Switch from "interval" to "fixed_interval" for aggs in datafeed configs #36758

droberts195 opened this issue May 21, 2019 · 3 comments · Fixed by #36759
Assignees

Comments

@droberts195
Copy link
Contributor

Following on from elastic/elasticsearch#41906 the ML UI needs to switch from using "interval" to using "fixed_interval" in aggregations starting with version 7.2, otherwise it will generate deprecation warnings in Elasticsearch.

The docs for "fixed_interval" are in https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations-bucket-datehistogram-aggregation.html#_fixed_intervals

A potential problem here is that "fixed_interval" does not support week as a unit, so if the UI was previously allowing "interval" to be specified in weeks these now need to be translated to days. ("fixed_interval" doesn't support month, quarter or year either, but these are variable length intervals, so would already have been causing problems in versions before 7.2 if they were used.)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@sophiec20
Copy link
Contributor

sophiec20 commented May 22, 2019

After team discussion, for 7.2 in the DATA FRAME UI, we will limit this to creating calendar_interval only and give the user a fixed selection of 1m, 1h, 1d, 1w, 1M, 1q, 1y (or minute, hour, day...).

The back-end will only support calendar_interval and fixed_interval and will not support interval. This removed risk of future bwc.

Therefore, if the user wishes to create a fixed_interval job, then this will be possible in dev tools.

@walterra
Copy link
Contributor

In 7.3 you can now also use the UI's advanced editor mode to switch to fixed_interval. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants