Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Docs entry: ui/public cleanup 7.2 #35683

Closed
lukeelmers opened this issue Apr 26, 2019 · 3 comments
Closed

Dev Docs entry: ui/public cleanup 7.2 #35683

lukeelmers opened this issue Apr 26, 2019 · 3 comments
Assignees
Labels
release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Apr 26, 2019

This issue is just there to create a single dev docs entry in the API changes blog post, for any of the ui/public directory removals, so not every removal PR pops up as it's own section in the blog post.

Dev Docs

ui/public cleanup

Relocated modules

In preparation for Kibana's upcoming new platform, we are in the process of migrating away from the ui/public directory. Over time, the contents of this directory will be either deprecated or housed inside a parent plugin. If your plugin imports from any of the following ui/public modules, you will need to update your import statements as indicated below, so that you are pulling these modules from their new locations.

ui/search_bar #35389

// deprecated
import 'ui/search_bar';

// new location
import { data } from 'plugins/data';
data.search.loadLegacyDirectives();

// deprecated
import { SearchBar } from 'ui/public/search_bar/components';

// new location
import { data } from 'plugins/data';
const { SearchBar } = data.search.ui;

ui/query_bar #35390

// deprecated
import 'ui/query_bar';

// new location
import { data } from 'plugins/data';
data.query.loadLegacyDirectives();

// deprecated
import { QueryBar } from 'ui/public/query_bar/components';

// new location
import { data } from 'plugins/data';
const { QueryBar } = data.query.ui;
@lukeelmers lukeelmers added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Visualizations Visualization editors, elastic-charts and infrastructure :AppArch v7.2.0 labels Apr 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukeelmers
Copy link
Member Author

lukeelmers commented Apr 26, 2019

Immediately closing this so the dev tools script can pick up docs changes for 7.2.

Please update the issue description with any ui/public cleanup items for 7.2 (but only use this issue for changes that will make it into 7.2)

@lukeelmers lukeelmers changed the title Dev Docs entry: ui/public cleanup 7.1 Dev Docs entry: ui/public cleanup 7.2 May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0
Projects
None yet
Development

No branches or pull requests

4 participants