Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Cross-linking to Uptime #35294

Closed
dov0211 opened this issue Apr 18, 2019 · 5 comments · Fixed by #35993
Closed

[Infra UI] Cross-linking to Uptime #35294

dov0211 opened this issue Apr 18, 2019 · 5 comments · Fixed by #35993
Assignees
Labels

Comments

@dov0211
Copy link

dov0211 commented Apr 18, 2019

Similar to the Uptime cross-link to Infra & Log UI #35133 we would like to allow a reverse integration from Infra UI to Uptime using the same fields (host.ip , container.id, kubernetes.pod.uid)
we should take a similar approach to the infra/apm integration #27319
@skh @simianhacker

@dov0211 dov0211 added the Feature:Metrics UI Metrics UI feature label Apr 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@dov0211 dov0211 changed the title Infra UI Cross-linking to Uptime [Infra UI] Cross-linking to Uptime Apr 18, 2019
@simianhacker
Copy link
Member

@dov0211 I just want to confirm the behavior here.

  • For Hosts, linking to Uptime should be done with host.name OR host.ip?
  • For Kubernetes, linking should be done via kubernetes.pod.uid?
  • For Docker, linking should be done via container.id?

What's the URL format we should use?

I would recommend that Uptime adopt the same strategy we are using in Infra/Logging with our link-to interface. It's a stable URL that then maps to the correct page in our system. This hides the implementation details on our end and allows us to make changes without affecting outside links.

@dov0211
Copy link
Author

dov0211 commented Apr 24, 2019

@simianhacker

For Hosts, linking to Uptime should be done with host.name OR host.ip?

we would like to use host.ip

For Kubernetes, linking should be done via kubernetes.pod.uid?
For Docker, linking should be done via container.id?

That is correct.

As for the URL format, I am adding @justinkambic @andrewvc

@justinkambic
Copy link
Contributor

justinkambic commented Apr 25, 2019

@simianhacker you can refer to this PR for the parameters we will accept: #35375

The format can look like:

http://localhost:5601/app/uptime#/?search=host.name%3Asomething

Essentially the search param will accept a KQL-formatted string. Here's another example:

http://localhost:5601/app/uptime#/?search=monitor.name%3Atest-page%20url.full%3Ahttp%3A%2F%2Flocalhost%3A12349%2Ftest-page%20monitor.status%3Aup%20url.port%3A12349%20monitor.type%3Ahttp

@simianhacker
Copy link
Member

simianhacker commented May 2, 2019

Based on a meeting between Uptime and Infra UI we've decided that we will need to stick with host.ip. The snapshot API will need to add host.ip field to the attributes returned for a node. Once that is available in the snapshot data then we can link out to Uptime the using the same technique for Logs and APM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants