Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Drop Redux dependency #34040

Closed
sorenlouv opened this issue Mar 28, 2019 · 2 comments
Closed

[APM] Drop Redux dependency #34040

sorenlouv opened this issue Mar 28, 2019 · 2 comments
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture

Comments

@sorenlouv
Copy link
Member

Currently we only use Redux for reacting to url changes, and then converting url params to proper types (eg "4" to number and "false" to boolean). We don't need Redux for this, and can simplify how url params are handled by moving it out.

Related to remix-run/react-router#6453 (comment)
@sorenlouv sorenlouv transferred this issue from elastic/apm Mar 28, 2019
@sorenlouv sorenlouv added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Mar 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@alvarolobato alvarolobato added [zube]: Inbox technical debt Improvement of the software architecture and operational architecture and removed [zube]: Inbox labels Apr 17, 2019
@jasonrhodes
Copy link
Member

Done in other tickets -- we no longer use Redux in APM. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasonrhodes @sorenlouv @elasticmachine @alvarolobato