Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom icons for management sections #32661

Closed
mattkime opened this issue Mar 7, 2019 · 4 comments
Closed

Allow custom icons for management sections #32661

mattkime opened this issue Mar 7, 2019 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@mattkime
Copy link
Contributor

mattkime commented Mar 7, 2019

Describe the feature:

Currently we only support EUI icons for kibana management sections. We should allow custom icons, particularly for third party developers.
@nreese nreese added the enhancement New value added to drive a business result label Mar 9, 2019
@cchaos
Copy link
Contributor

cchaos commented Mar 18, 2019

The best way to provide this and keep BWC is to use an EuiImage with the custom svg source url as the src if the passed icon is not of EuiIcon.type.

@lukeelmers lukeelmers mentioned this issue Aug 16, 2019
Closed
@lukeelmers lukeelmers added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:AppArch labels Aug 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@cchaos
Copy link
Contributor

cchaos commented Aug 19, 2019

Since I commented back in March, EuiIcon now allows custom svg's or url's to be passed as the type so it doesn't need to be a EuiImage.

@mshustov mshustov mentioned this issue Sep 9, 2019
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Oct 7, 2021

Appears to be addressed by cchaos

@mattkime mattkime closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mattkime @nreese @cchaos @lukeelmers @elasticmachine