Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] selectedLayerId redux store clean-up #31532

Closed
nreese opened this issue Feb 19, 2019 · 3 comments
Closed

[Maps] selectedLayerId redux store clean-up #31532

nreese opened this issue Feb 19, 2019 · 3 comments
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation

Comments

@nreese
Copy link
Contributor

nreese commented Feb 19, 2019

selectedLayerId is currently in the map tree of the redux store. It is more of a UI concern and should be moved under ui.

__transientLayerId is not needed since it will always contain the same value as selectedLayerId. Should be replaced with something like isSelectedLayerTransient.
@nreese nreese added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Feb 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese nreese mentioned this issue Feb 19, 2019
Merged
@kindsun
Copy link
Contributor

kindsun commented Feb 19, 2019

TBD, but we might be able to cover this under #31540

@thomasneirynck thomasneirynck mentioned this issue Feb 26, 2019
Merged
@nreese
Copy link
Contributor Author

nreese commented Apr 12, 2021

Closing. Not really important or worth changing.

@nreese nreese closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @kindsun @thomasneirynck @elasticmachine