Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] (Accessibility) Read summary info for File contents and Summary stats #31117

Closed
aphelionz opened this issue Feb 14, 2019 · 3 comments
Closed

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Navigate to Machine Learning
  2. Tab to Data Visualizer
  3. Upload a valid file
  4. Navigate to the next screen

screenshot_20190214_082856

Actual Result

  1. The tab order skips all relevant content and only focuses on the textarea and the "Override Settings" button

Expected Result

  1. Consider amending the markup of these sections to include some summary info i.e. "First 1000 lines" or the stats starting with "Number of Lines Analyzed"

Meta Issue #26855

Kibana Version: 6.5

Relevant WCAG Criteria: 1.3.1 Info and Relationships

@peteharverson peteharverson changed the title (Accessibility) File contents and stats might want to consider reading summary info [ML] (Accessibility) File contents and stats might want to consider reading summary info Feb 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson changed the title [ML] (Accessibility) File contents and stats might want to consider reading summary info [ML] (Accessibility) Read summary info for File contents and Summary stats Mar 7, 2019
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Apr 8, 2019
@PhilippBaranovskiy
Copy link
Contributor

The described way of hitting tab to go throughout the content is not supposed to work this way in the world of screen readers.
Tabbing is supposed to let the user to go throughout the interactive items such as links, button, selects.

I've tested this functionality with NVDA and Jaws screen readers on Windows (which is supposed to be the app that is used by real people in real life) as well as with VoiceOver on Mac — it works correctly with the current implementation.

It does due to the fact that the working with page content happens in a slightly different way neither switching focus from one item to another.
If I need to go to the next piece of content, I just hit the key. That's how I read it line by line (that's what this issue is about).

For instance, for VoiceOver those commands are:

  • Control + + + H: go to the "Summary" heading
  • Control + + + shift ⇧ + H: go back to the "File contents" heading
  • Control + + : to go to the "Number of lines analyzed" and so forth

For NVDA (Win) keys are slightly different:

  • H: go to the "Summary" heading
  • shift ⇧ + H: go back to the "File contents" heading
  • Control + : to go to the "Number of lines analyzed" and further

On the following video you can see how that works with VoiceOver on Mac:

voice_over

@PhilippBaranovskiy
Copy link
Contributor

I'm closing this as the current implementation is correct, — explanation is in the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants