Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ids are still saved within attributes of saved objects and not into references #30455

Closed
mikecote opened this issue Feb 8, 2019 · 4 comments
Assignees
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mikecote
Copy link
Contributor

mikecote commented Feb 8, 2019

Based on a few CI logs I've added in a branch (#30418), I've created a list of object types and paths I've noticed are still storing ids within attributes. Not all below need to be converted but need to be discussed with impact on saved object export / import.

Object Type: config
Path: attributes.defaultIndex

Object Type: url
Path: attributes.url

Object Type: visualization
Path: attributes.visState.params.controls[x].indexPattern

Object Type: map
Path: attributes.layerListJSON[x].sourceDescriptor.indexPatternId
Path: attributes.layerListJSON[x].joins[x].right.indexPatternId

Object Type: canvas
Path: attributes.id

@mikecote mikecote added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 8, 2019
@mikecote mikecote self-assigned this Feb 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@mikecote
Copy link
Contributor Author

mikecote commented Feb 8, 2019

Added the following to the description:
Object Type: map
Path: attributes.layerListJSON[x].joins[x].right.indexPatternId

Object Type: canvas
Path: attributes.id

@mikecote
Copy link
Contributor Author

As discussed with @spalger, we'll skip url and config for now as they won't be part of import / export. I will create a PR to resolve visualization and canvas.

GIS team is working on a PR for map.

@mikecote
Copy link
Contributor Author

#31745 will resolve map and then this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants