Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Support custom fields in Metric-dropdown #30197

Closed
makwarth opened this issue Feb 6, 2019 · 6 comments
Closed

[Infra UI] Support custom fields in Metric-dropdown #30197

makwarth opened this issue Feb 6, 2019 · 6 comments
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@makwarth
Copy link

makwarth commented Feb 6, 2019

Motivation

Enable customers to customize the active Metric in the Infra UI. We already implemented this for the Group By dropdown in 6.6

Proposal

For both Metric and Group by, add/move dropdown for searching and selecting a custom field to the top of the dropdown element. Mockup:

screenshot 2019-02-06 at 13 27 13

For Metric, we'd ideally only show fields that contains metrics. For Group By, only keywords.

Selecting a field in the auto-suggestion popover, will pin that field to the dropdown and activate it. (Like it works for Group By now). Custom fields are currently "just" stored as part of the URL.

UI polish

It'd be nice if the auto-suggestion popover had the width of its content, so users don't end up with this and need to hover each suggestion to see complete field name.

screenshot 2019-02-06 at 13 27 50

@makwarth makwarth added the Feature:Metrics UI Metrics UI feature label Feb 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@simianhacker
Copy link
Member

A couple of challenges stand out to me....

Just picking a field is not enough because we need to know "how" to aggregate the metric. A good example is anything that's a "counter" style metric like system.network.bytes.out requires derivative(max(system.network.bytes.out)) to display the rate.

There are also metrics like disk usage (and network usage), we don't have a single metric, the user will need to specify which disk (or interface) they are concerned with. They might need to do something like avg(system.filesystem.used.pct{system.filesystem.mount_point:/data}).

@makwarth
Copy link
Author

@simianhacker Yeah, you're right. As for the metrics like disk and network usage, the group by dropdown will help, or..? For aggs, does it make sense to have a few pre-build aggregation options, like counter to rate? The user will manually have to select and agg (unless we do some guessing on the metric name) and will only help in common cases. Thoughts?

@ruflin
Copy link
Contributor

ruflin commented Feb 12, 2019

Having a manual option to get started sounds like a good idea. Long term I would like to see that Beats tells Kibana / the UI what kind of metric it actually is (counter, gauge) so the UI can automatically make this decision.

@sgrodzicki sgrodzicki added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Feb 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker
Copy link
Member

Closing in favor of #50193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants