Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Adapt to Elasticsearch total hit count response format change #26351

Closed
weltenwort opened this issue Nov 28, 2018 · 3 comments
Closed
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.0.0

Comments

@weltenwort
Copy link
Member

weltenwort commented Nov 28, 2018

Once elastic/elasticsearch#35849 is merged into master, any usages of the hit count will fail. There are two steps we should take to mitigate this:

  1. Force the response to match the previous format by adding rest_total_hits_as_int=true as a query parameter to the requests in both master and 6.x. (PR [Infra UI] pass flag in request to force BWC hit count #26517)
  2. While this means there is no divergence between master and 6.x for now, it will have to be replaced with the new format before 8.0.0. This will happen in [Infra UI] Remove deprecated total_hits request parameter #29435.

Current usages

@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@alvarolobato
Copy link

The second bullet will be executed after the 7.0 branch is created.

@weltenwort
Copy link
Member Author

The second step is tracked in #29435.

@zube zube bot added [zube]: Done and removed [zube]: Ready labels Jan 28, 2019
@zube zube bot reopened this Jan 28, 2019
@zube zube bot added [zube]: Ready and removed [zube]: Done labels Jan 28, 2019
@zube zube bot closed this as completed Jan 28, 2019
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Jan 28, 2019
@alvarolobato alvarolobato added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services and removed [zube]: Done labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.0.0
Projects
None yet
Development

No branches or pull requests

3 participants