Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Calendar conversion to React #25970

Closed
30 tasks done
alvarezmelissa87 opened this issue Nov 20, 2018 · 2 comments
Closed
30 tasks done

[ML] Calendar conversion to React #25970

alvarezmelissa87 opened this issue Nov 20, 2018 · 2 comments
Assignees

Comments

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Nov 20, 2018

Meta Issue to track progress on Calendar conversion to React.

Calendars conversion

PR: #26741

  • list page
    • display table
    • order by id, job, events
    • can trigger delete
      • delete confirmation modal on delete
    • edit button functionality
    • new button functionality
  • new/edit calendar form
    • validation of calendar id
    • able to create new calendar
    • able to edit existing calendar
    • 'Cancel' button navigates back to calendar list
    • populate job/group options
    • able to add new group
    • edit: disable changing calendar_id
  • event list
  • create new events
    • Current functionality: If user inputs in To a time that is earlier than From, From is updated to be one day before (and vice versa). Open to opinions on this.
  • import events
  • Error handling - toast with error message and 'try again'
  • Permissions
    • Create Calendar
      • disabled if canCreateCalendar === false || mlNodesAvailable === false
    • Delete Calendar
      • disabled if canDeleteCalendar === false || mlNodesAvailable === false

Follow up:

Designs

cc @pheyos - this update will definitely affect any ui tests you have for Settings/Calendar management.
Wanted to give you a heads up! Let me know if you have any questions.

  • List page:

image

  • Delete calendar modal:

image

  • Create form:

image

  • Edit form:

image

  • Create Events:

image

  • Import Events:

image

  • Import Events Error:

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson
Copy link
Contributor

Closing as addressed by #26741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants