-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events refering to a non existing parent event are not shown in waterfall. #24827
Comments
Pinging @elastic/apm-ui |
I don't think there is away of showing spans whose parent is missing. We can only add a warning on the trace level that there are spans missing. The problem is that we don't know where to put the span tree. Especially when we have the tree navigation (#20660). |
@simitt if possible, can you provide a link to this problem (minus hostname and I can load it locally or in the cloud instance)? I suspect this is just the services legend problem but your description makes it sound like it might be more than that, so I'd like to take a look. Thanks! |
@jasonrhodes I tested this locally, so I cannot link to that unfortunately. However, I have a copy of the docs if that helps. |
@simitt thanks for the info. @alvarolobato this sounds like a different issue but one that would take some thinking, so probably not for 6.5, if you want to move this ticket wherever it should go to be thought about post-6.5 release. |
Are the missing spans from the node-agent? @watson could this be related to the issue you are working on? |
@alvarolobato elastic/apm#9 is the related issue (also linked above). |
I agree with @felixbarny comment:
Since we construct the tree structure top-down, spans that don't have any parent will be orphans and never included. AFAICT there is no way for us to add them to the tree. I'm fine with keeping the current behaviour, and leaving out spans whose parent is missing. At the very least for the upcoming release. In the future we could add a message about missing transactions/spans like in #24320 Any objections? |
We agreed on this approach a while back, so 👍 |
Cool, did we write this down anywhere, and can I close this issue? |
Superseeded by #25117 |
Scenario:
Testing the UI for distributed tracing with opbeans created data. Click on traces and choose opbeans-go
GET /api/orders
. The transaction sample shows following waterfall:Issue:
Afaik the events should still be shown, but with a message that some events are missing.
I also saw that the opbeans-python events had a timestamp ~30mins later then other events of this trace.
The text was updated successfully, but these errors were encountered: