Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discover chart and url do not update when default index is changed #2480

Closed
jthomassie opened this issue Dec 29, 2014 · 6 comments
Closed

discover chart and url do not update when default index is changed #2480

jthomassie opened this issue Dec 29, 2014 · 6 comments

Comments

@jthomassie
Copy link

  1. Open Kibana (shows Discover tab and default index data by default)
  2. Select Settings tab, change default index
  3. Select Discover tab, shows previous index in url and chart
@jthomassie jthomassie added the bug Fixes for quality problems that affect the customer experience label Dec 29, 2014
@rashidkpc
Copy link
Contributor

Not sure if this is a bug, or rather just a behavior. We store the last state of each app. The index pattern is included in the state, so when you click back to discover, you're really just reloading the state you were in. If you were to somehow end up in a default discover state you'd get the default index pattern.

@jthomassie
Copy link
Author

if I delete the url after changing default index and after selecting discover tab, the prev default index renders in the chart but the url shows the new default

@jthomassie
Copy link
Author

it seems the last state in the url and the rendered chart can be different.
I'm working makelogs and with a non-time-based index, so it's more obvious when they're out of sink (no discover chart, just table)

@babadofar
Copy link

It looks like I stumbled upon a similar issue. Go to settings, select another index pattern, click on Discovery, and contents from the previous index is shown, it shows also the previous index name in the field list. I couldn't find an obvious way to force it to change, other than deleting the query string from the url.
When you select another index pattern in settings, I feel it would be natural to also change the selected index pattern in all panels.

@BigFunger
Copy link
Contributor

Confirmed, if you manually reset the state of the app by modifying the query-string, then it resets to the default index. However, is that the work-flow that we expect our users to follow?

IMO, As a user, if I go into the settings and change the selected default index, I expect that the next time I navigate to the Discover tab, the new default index will be selected. I expect the application to do whatever it needs to do to establish that state.

@epixa epixa added release_note:enhancement :Discovery and removed bug Fixes for quality problems that affect the customer experience labels Dec 26, 2016
@spalger spalger added won't fix and removed discuss labels Jan 2, 2017
@spalger
Copy link
Contributor

spalger commented Jan 2, 2017

We considered adapting this in a few ways:

  • when the user hasn't chosen a specific index pattern, persist that they are using the "default" index pattern in state so that on the next load the new default index pattern is loaded
    • what happens when the field list changes dramatically?
    • does discover need to start diff-ing the contents index patterns to know when it can/can't reload a state?
  • when the default index pattern is changed, and the discover state points to the old index pattern, wipe out the discover state

That's when we decided we didn't like any of our options, and that this probably isn't going to happen. Additional rationale:

  • it's two years old
  • not much community support
  • persisting the state of an app when you leave it is just how kibana apps work
  • resetting the app state no longer requires modifying the url, just click the app icon/name again and voila

If you think you've got a solution that works when taking this all into account feel free to open another issue

@spalger spalger closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants