Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Action menu: Link trace.id to Logs UI #23317

Closed
makwarth opened this issue Sep 19, 2018 · 10 comments · Fixed by #34310
Closed

[APM] Action menu: Link trace.id to Logs UI #23317

makwarth opened this issue Sep 19, 2018 · 10 comments · Fixed by #34310
Assignees
Labels
Team:APM All issues that need APM UI Team support

Comments

@makwarth
Copy link

makwarth commented Sep 19, 2018

Edit: 3/26/2019: Updating description as original description didn't make any sense.

Add link to transaction Actions menu: Show trace logs. The link will take the user to the Logs UI, filtered by a text search on the value of trace.id. Let's discuss if the link should be conditional or static.

Example:
Screenshot 2019-03-26 at 10 12 48

@makwarth makwarth added Team:APM All issues that need APM UI Team support v6.6.0 labels Sep 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@makwarth
Copy link
Author

Blocked by #23316

@alvarolobato
Copy link

Felix is planing to put some work on this one (#23316) soon to allow liking from Monitoring, which should unblock this.

@jasonrhodes
Copy link
Member

@alvarolobato @makwarth We currently have a list of links that get created based on the current transaction we're viewing in the "Actions" dropdown. Can we add detail to this ticket description to explain when we want to include the trace ID, for which links? All links in the actions dropdown, or a new link, etc? Thanks!

@jasonrhodes
Copy link
Member

@weltenwort I'm looking at this as well a comment you and Alvaro made earlier this week in Slack:

Alvaro: Links on the dev environment from APM to infra UI seem to be broken, did anyone see it?

Felix: looks like APM is linking to a host even though the entity is a k8s pod, and it still uses the pod name instead of the uid

Can you give me some more context on this and how I could reproduce it? I need to get more familiar with the infra side, maybe a zoom would be useful on Monday if you have time. Thanks!

@weltenwort
Copy link
Member

I saw from the URL that @alvarolobato shared, that it is a link to metrics of a host with the host id looking like a k8s pod name. When navigating to that URL, the Infra UI in Kibana reponds with an error message that no such host exists. Two things seem to contribute to that problem here:

  • The links to metrics and logs in the "actions" menu try to show the "Host logs" and "Host metrics" using the k8s pod name and not the underlying hostname.
  • Even if the links referred to "pods" instead of "hosts", these are referred to using their ids and not names, since those are not well suited as a unique identifier.

grafik

grafik

@makwarth makwarth changed the title [APM] Link trace_id to Infra UI [APM] Action menu: Link trace.id to Logs UI Mar 26, 2019
@jasonrhodes
Copy link
Member

Let's discuss if the link should be conditional or static.

We decided via Slack conversation to make this link work like all the others, i.e. conditional on the value it requires for the link (trace.id here)

@jasonrhodes
Copy link
Member

@makwarth I see you only mention the logs UI here but the other links in this menu all come in pairs, one to logs and one to metrics. Is that on purpose?

I'm also checking to see if it's possible to link to the logs only by trace ID, because the linked ticket only mentions trace ID being possible as a secondary filter (the examples all do link-to/host-metrics/{host}?filter=trace.id=whatever etc)

@makwarth
Copy link
Author

makwarth commented Apr 1, 2019

@jasonrhodes Yes, since CPU/Mem metrics documents don't have trace.id

@jasonrhodes
Copy link
Member

@makwarth ah yes, good reason! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants