Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana should have a strict mode that fails on Elasticsearch deprecation warnings #22815

Closed
LeeDr opened this issue Sep 7, 2018 · 1 comment
Labels
build enhancement New value added to drive a business result stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team

Comments

@LeeDr
Copy link

LeeDr commented Sep 7, 2018

Describe the feature: Kibana should run tests in a mode where Kibana or the tests fail if we get deprecation warnings from Elasticsearch on requests. Since we couldn't immediately address every deprecation warning we would also need a way to skip or ignore a list of warnings until they were addressed.

Describe a specific use case for the feature: There was a recent issue on Cloud, and customers running through a proxy where the connection was closed after hitting some number of warnings.

Here's one example of the type of warnings; #22484

And the user problems https://discuss.elastic.co/t/bad-gateway-errors-in-discover-in-kibana-6-4-on-some-indices/146576

Elasticsearch issues: elastic/elasticsearch#33479
elastic/elasticsearch#33508

@LeeDr LeeDr added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc build enhancement New value added to drive a business result labels Sep 7, 2018
@LeeDr LeeDr added the Team:Operations Team label for Operations Team label Sep 7, 2018
@jbudz
Copy link
Member

jbudz commented Jan 30, 2019

I looked into this, I'd propose a new configuration elasticsearch.logDeprecations (log level = warn) that is true in dev. These are available in response headers from elaticsearch, and currently only available in the callback style response in the elasticsearch-js client ref. The next version will support this in promise style, so I'm going to hold off for now so we can avoid multiple low level changes.

@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New value added to drive a business result stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants