Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate non-angular plugins to new platform toasts #21948

Closed
spalger opened this issue Aug 14, 2018 · 5 comments
Closed

Migrate non-angular plugins to new platform toasts #21948

spalger opened this issue Aug 14, 2018 · 5 comments

Comments

@spalger
Copy link
Contributor

spalger commented Aug 14, 2018

With #21772 the <EuiGlobalToastList/> is now injected in every page and as such we should remove usage of the <EuiGlobalToastList/> from other plugins that previously needed to supply it themselves because they were not using angular. If two <EuiGlobalToastList/>s are rendered in the same page the toasts will overlap each other so we need to unify our usage.

Based on my searches APM [1] [2] seems to be the only plugin that will need to be updated, but pinging people related to other plugins just to make sure.

@w33ble @weltenwort @sqren

@sorenlouv
Copy link
Member

@spalger
Copy link
Contributor Author

spalger commented Aug 14, 2018

That API is unchanged and is currently the easiest way to integrate with the toastNotifications

@w33ble
Copy link
Contributor

w33ble commented Aug 15, 2018

You're saying that as long as we don't use the EuiGlobalToastList component ourselves, we're good? Because canvas does not use that.

@spalger
Copy link
Contributor Author

spalger commented Aug 15, 2018

Yep, thanks @w33ble

@sorenlouv
Copy link
Member

@spalger This should be solved by #22056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants