"Click to add filter" should allow adding inverse of filter

[trevan]

The filter bar work in #2120 is nice but I sometimes want to be able to click in a visualization and have that value filtered for negated.

[magnusbjarnlid]

This is also important to us. Being able to remove certain entries is important when analyzing e.g. log files.

[rashidkpc]

Agreed it would be really nice to have the ability to negate a filter before actually running it. Would love input on how the interaction should work here. Modifier key? I want to avoid popups.

[thomasneirynck]

Indeed, you can invert the filter by clicking on the invert-button when the filter is added to the filter-toolbar

In visualizations, you can also click on them on the legend and either apply the filter (the +magnifier) or the inversion of it (the -magnifier).

Let's close this since there are two available work-arounds. They also avoid the need for a more complicated UX-flow to do this transparently (e.g. with a modifier-key, or right click with context menu).

[trevan]

The problem with the work arounds is that the first one (negate in the filter bar) causes two lookups to elasticsearch which can be pretty intensive. The second one, only is available in a few cases.

So they really aren't that great of work-arounds. Maybe instead of auto submitting the new filter, it can let you edit the filter? This is used when you add more than one filter at a time already (though without the editing).

[trevan]

Or, what about allowing plugins to hook into the click event. Then a plugin can add right click menus, modifier-key, etc.

[thomasneirynck]

@trevan fair enough, I'll reopen to reflect that work-arounds have some drawbacks.

As for the API suggestion, a documented public interface for plugins is lacking right now. But it's something that is on the table. The ability to hook into click events (or manage the filter bar for that manner), are things that will need to be taken into account when it does come around. If you have more ideas about what you'd like to see in a public plugin API, please don't hesitate to open an enhancement ticket.

[timroes]

I think that issue is no longer relevant? With the filter bar editor you have all the negated options as "operators" available (like is not, is not between, etc.) that will add that filter in a negated state. And visualizations via their legend and discover table currently already support adding negated filters directly.

I think adding some APIs around that should not be tracked in that issue.

I'll close this issue, but please feel free to leave a comment, if you still consider it relevant.

[trevan]

@timroes, per my comment #2184 (comment), this is not fixed.

This isn't talking about being able to create a negative filter from the filter bar. This is about clicking on items in visualizations and creating a negative. The table and legend are only available for some of the possibilities. And clicking on an item and then negating can be painful to the elasticsearch cluster and causes an unnecessary search.

Maybe if #17844 is done, then at least the extra search can be stopped early. But it would still be nice to not cause the unnecessary search.

#6189 is for the api change.