Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/alerts/custom_threshold_preview_chart·ts - ObservabilityApp Custom threshold preview chart does render the empty chart only once at bootstrap

[kibanamachine]

A test failed on a tracked branch

Error: expected testSubject(ruleTypeModal) to exist
    at TestSubjects.existOrFail (test_subjects.ts:76:13)
    at Object.clickOnObservabilityCategory (rules_page.ts:50:5)
    at Context.<anonymous> (custom_threshold_preview_chart.ts:47:7)
    at Object.apply (wrap_function.js:74:16)

First failure: kibana-on-merge - main

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[kibanamachine]

New failure: kibana-on-merge - main

[kibanamachine]

New failure: kibana-on-merge - main

[maryam-saeidi]

Summary of Slack discussion:

As shown below, we check if the Create rule button exists and then we try to click it:

const clickCreateRuleButton = async () => {
    await testSubjects.existOrFail('createRuleButton');
    const createRuleButton = await testSubjects.find('createRuleButton');
    return await createRuleButton.click();
  };

It seems something goes wrong during click in this case and even after 2 mins, we don't see the modal:

[00:03:11]         │ debg --- retry.tryForTime error: [data-test-subj="ruleTypeModal"] is not displayed
...
[00:05:09]         └- ✖ fail: ObservabilityApp Custom threshold preview chart does render the empty chart only once at bootstrap

@dmlemeshko pointed to the implementation that we have for the button and the fact that we need to first check if the user is authorized to see this button, and something might have caused the click not to be successful even though there is no error reported by WebDriver.

useEffect(() => {
    setHeaderActions?.([
      ...(authorizedToCreateAnyRules ? [<CreateRuleButton openFlyout={openRuleTypeModal} />] : []),
      <RulesSettingsLink />,
      <RulesListDocLink />,
    ]);
  }, [authorizedToCreateAnyRules]);

Long story short, we will add waiting for the global spinner to hopefully make this test less flaky 🤞🏻

[kibanamachine]

New failure: kibana-es-forward-compatibility-testing-9-dot-0 - 8.x

[kibanamachine]

New failure: kibana-on-merge - 8.18

[maryam-saeidi]

Maybe I should backport my PR to 8.19 and 8.18 🤔