[UII] Convert deployment mode selector to radio group #208859
+149
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @jen-huang |
| defaultMessage="Agentless" | ||
| />{' '} | ||
| <EuiBetaBadge | ||
| label="Beta" |
There was a problem hiding this comment.
a bit unrelated, I'm wondering when the Beta badge is planned to be removed?
seanrathier
approved these changes
Jan 30, 2025
| @@ -86,6 +86,11 @@ export function useSetupTechnology({ | |||
| const orginalAgentPolicyRef = useRef<NewAgentPolicy>({ ...newAgentPolicy }); | |||
| const [currentAgentPolicy, setCurrentAgentPolicy] = useState(newAgentPolicy); | |||
|
|
|||
| const allowedSetupTechnologies = useMemo(() => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/ingest-dev/issues/4507. This PR converts the drop down selector in policy editor for
Agentless/Agent-basedto a radio group.Closes #208861. This PR also fixes an issue where
Agent-basedoption was still available even when integration only specifies agentless deployment mode.The selector used by the custom editor for CSPM integration was already converted to radios in #208645. This PR handles the conversion for the generic editor used by other agentless integrations such as
elastic_connectors. It also makes minor formatting changes to the CSPM one to bring the two visually in line:Generic:
CSPM:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines