Auto refresh is no longer working

[timroes]

Enabling auto refresh won't cause any additional requests to be send periodically anymore (this issue is not yet released).

This was caused by #20295

[nreese]

Talked to @spalger about moving all auto refresh timeout management logic into timefilter. Spencer suggested that it did not make sense and the better long term solution would be creating a new service to handle auto refresh state and timeout logic.

SearchPoll throttles the refresh interval timeout to the speed that courier can execute when the interval is too fast. This logic should be pulled out of Courier and put into the auto refresh service so that the timeout logic can be throttled to the speed for the slowest request when the interval is too fast.

We talked about just having SearchPoll emit an event on timefilter that could be subscribed to as a short term solution for 6.4. I have put up a WIP PR demonstrating this solution.

cc @stacey-gammon @markov00 @cjcenizal

[LeeDr]

I guess this means there aren't any tests that verify auto refresh? Would that have to be a UI functional test or is there some more efficient way?

[stacey-gammon]

Nope 😭 A glaring gap that I've been aware of for awhile but never found time to cover. Actually you can see this comment in our team meeting notes from back in April:

I'd like to add some auto refresh tests and time zone tests first. This will also be important for the search source clean up since that is very fragile code.

If I recall correctly I did add some timezone tests in there but never got around to the auto refresh ones.

I think this would have to be functional because of all the moving parts and the interaction with courier.

[timroes]

Fixed by #20863 - will create a follow up ticket for a proper solution as outlined by Nathan, that will introduce a new service