Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Trace timeline: Collapse spans faster than 95% of total trace duration #20659

Closed
formgeist opened this issue Jul 11, 2018 · 4 comments
Closed
Labels
apm:waterfall Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Jul 11, 2018

APM UI – Distributed tracing – Timeline visualization meta issue #20553


Summary

In an effort to condense the Timeline visualization, we'd want to collapse spans that are fast, since we deem them not important to analyze performance bottlenecks. The information still needs to be available, but we'll condense the spans that are faster than 95% of the total trace duration.

We'll only collapse if consecutive spans are eligible to be collapsed. So if a single span is eligble, we'll let it be. In most cases you might have a repeating pattern of fast resources that might as well be condensed.

Design

Displaying collapsed spans happens in the nested relation visualization on the left of the timeline.

04 dt - timeline - condensed span rows and gradient overflow

Use the grab icon from EuiIcon to indicate collapsed spans. Show number of collapsed spans. Let the span graphs show on the Timeline.

The icon and summary will be a toggle to expand those spans anyway, but only that set of collapsed spans. There's no control to collapse the spans again, besides reloading the page. We might consider adding controls for both the % of duration the spans are collapsed along with an option to expand / collapse all at a later stage depending feedback.

@formgeist formgeist added the Team:APM All issues that need APM UI Team support label Jul 11, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@alvarolobato
Copy link

I've lowered the priory of this specific one within DT.

@sorenlouv
Copy link
Member

Deferred to 6.6

@sorenlouv sorenlouv changed the title [APM] Collapse spans faster than 95% of total trace duration [APM] Trace timeline: Collapse spans faster than 95% of total trace duration May 14, 2020
@formgeist
Copy link
Contributor Author

We fixed most of the issues with long trace waterfalls by implementing #106862 so no need to continue with the threshold approach at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:waterfall Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants