Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete in dev tools console for SQL endpoints #20570

Closed
zuketo opened this issue Jul 9, 2018 · 7 comments
Closed

Autocomplete in dev tools console for SQL endpoints #20570

zuketo opened this issue Jul 9, 2018 · 7 comments
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@zuketo
Copy link

zuketo commented Jul 9, 2018

Provide autocomplete for any SQL endpoints in the dev tools console. In addition to autocomplete for the endpoint, autocomplete can also be used for the structure of the request:

E.g.
POST /_xpack/sql?format=txt
POST /_xpack/sql?format=json
POST /_xpack/sql/close
POST /_xpack/sql/translate
...

CC @costin

@alexfrancoeur
Copy link

@bmcconaghy @yaronp68 probably something we should introduce sooner than later. I know Bill has recently added a ton of new functionality to Console autocomplete. Is this something we can get into 6.4?

@costin
Copy link
Member

costin commented Aug 28, 2018

As far as I'm aware this did not make it to 6.4; is 6.5 a reasonable target?

@bmcconaghy
Copy link
Contributor

@costin the endpoint definitions did make it into 6.4:
image

However, the body definitions did not. This might be something we can squeeze into 6.5 depending on the progress of other work, but at this point 6.6 seems more likely.

@costin
Copy link
Member

costin commented Aug 28, 2018

Thanks @bmcconaghy !

@costin
Copy link
Member

costin commented Nov 8, 2018

Any update on this front? The issue is somewhat similar to #20580.

As a separate issue, we received feedback that due to quoting being common inside queries, it would be better to use triple quotes """ instead of single ones. Is there a way to incorporate this in? Should I create a different issue for this?

Thanks!

@yaronp68 yaronp68 added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Dec 5, 2018
@alexfrancoeur
Copy link

Just dropping this in here. If we are able to provide autocomplete for SQL and/or a SQL mode (#20580) for console, it'd be really nice if it was built it a way that could easily be re-used in other portions of the UI. Particularly Canvas. SQL is the only way to create aggs in Canvas today and likely for some time. Any way we can improve that experience would be huge.

@cjcenizal cjcenizal added the Feature:Console Dev Tools Console Feature label May 8, 2019
@jloleysens
Copy link
Contributor

I am closing this issue for now since Console does have vastly improved SQL support since #51446 was merged.

If we have more specific requirements we can open separate/new issues for it.

it'd be really nice if it was built it a way that could easily be re-used in other portions of the UI

The current autocomplete implementation in Console is specific to the Console editor. However we do have support for token highlighing in Elasticsearch SQL in monaco as exposed by the packages/kbn-monaco/src/xjson package which uses packages/kbn-monaco/src/esql. It would be great to contribute to that package to improve SQL support everywhere Monaco is used (hopefully Console will also use Monaco one day #57435)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

8 participants