Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Test and fix EUI theme Borealis applied to Rule Management features #204737

Open
banderror opened this issue Dec 18, 2024 · 5 comments
Assignees
Labels
9.0 candidate bug Fixes for quality problems that affect the customer experience EUI Visual Refresh Feature:Rule Details Security Solution Detection Rule Details page Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@banderror
Copy link
Contributor

banderror commented Dec 18, 2024

Related to: #199715

Summary

First initial testing done by @banderror revealed no major issues with the features owned by the @elastic/security-detection-rule-management team. In fact, the new theme looks very nice! A few very minor issues were noticed that are logged below.

We should regression test our UIs and follow #199715 for the work that needs to be done in the code.

Todo

TBD

Noticed issues

Colors

Some colors that we use for rule status and severity indicators seem off.

Current theme Borealis
Image Image
Image Image
@banderror banderror added 9.0 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Details Security Solution Detection Rule Details page Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Dec 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror banderror changed the title [Security Solution] Test and fix EUI theme Borealis applied to Rule Management features (DRAFT) [Security Solution] Test and fix EUI theme Borealis applied to Rule Management features Dec 18, 2024
@JasonStoltz
Copy link
Member

@banderror Interesting issue you're experiencing!

My hunch is that you are using euiColorVis colors for those. As part of the advice for Borealis, we are asking folks to discontinue using those outside of data visualizations.

My recommendation here is to stick with the EuiHealth component here (if you're not using it already) and using the colors as described in the example:

<EuiHealth color="subdued">Inactive</EuiHealth>
<EuiHealth color="primary">Active</EuiHealth>
<EuiHealth color="success">Healthy</EuiHealth>
<EuiHealth color="warning">Warning</EuiHealth>
<EuiHealth color="danger">Failure</EuiHealth>

CC @gvnmagni and @mgadewoll to see if they agree!

@gvnmagni
Copy link

thank you Jason and thank you @banderror . I am aware of this case, @codearos shared this to me few days ago since I was trying to map different uses of severity levels across the product.

We have been working on a Severity Color Palette that might help you out here, it is still a work in progress but you can already find a description here (Issue & conversation) and a PR made by Lene here that introduces tokens (PR).

If you like the idea, and I would love to hear from @codearos here first maybe, we could try use colors coming from this palette.

If, instead, you prefer a quick fix, we can try to match similar color to the ones you had in Amsterdam and make the best out of this (the reason why colors changed is bacause Datavis colors palette have been updated and they don't follow the same logic as before, this is why we have undesired results now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 candidate bug Fixes for quality problems that affect the customer experience EUI Visual Refresh Feature:Rule Details Security Solution Detection Rule Details page Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

5 participants