Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] EUI Visual Refresh Integration and QA #204591

Open
9 tasks
cqliu1 opened this issue Dec 17, 2024 · 3 comments · May be fixed by #204434
Open
9 tasks

[Maps] EUI Visual Refresh Integration and QA #204591

cqliu1 opened this issue Dec 17, 2024 · 3 comments · May be fixed by #204434
Assignees
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Dec 17, 2024

Related to #203132.

This issue is for tracking work that needs to be done for the EUI Visual Refresh for the Maps plugin specifically.

Checklist

  • All usages of "success" colors have been updated to "accentSecondary" and "textAccentSecondary" as needed (details).
  • All usages of "successText" colors have been updated to "textAccentSecondary" as needed (details).
  • (Required) All references to renamed tokens have been updated to use the new token name. (details)
  • (Required) All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa. (details)
  • (Required) The person assigned to "Design QA" has reviewed the UI with the new changes and is ready to ship.
  • All usages of vis colors for non-visulalization usage have been removed in favor of other EUI color tokens, where possible. (details)
  • All "Custom colors" have been replaced with EUI color tokens. (details)
  • All usages of color functions have been removed in favor of color tokens, where possible. (details)
  • All usages of JSON tokens have been removed in favor of color tokens, where possible. (details)

Known Bugs

  • [ ]
@cqliu1 cqliu1 changed the title [Maps] [Maps] EUI Visual Refresh and QA Dec 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 changed the title [Maps] EUI Visual Refresh and QA [Maps] EUI Visual Refresh Integration and QA Dec 17, 2024
@cqliu1 cqliu1 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas EUI Visual Refresh labels Dec 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 added loe:medium Medium Level of Effort and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas EUI Visual Refresh labels Dec 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas EUI Visual Refresh labels Dec 17, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas EUI Visual Refresh labels Dec 17, 2024
@botelastic botelastic bot added needs-team Issues missing a team label and removed needs-team Issues missing a team label labels Dec 17, 2024
@cqliu1 cqliu1 linked a pull request Dec 17, 2024 that will close this issue
9 tasks
@jsanz
Copy link
Member

jsanz commented Dec 17, 2024

Maps flyouts are not getting the same color other Lens/Dashboad panels

Screenshots

Image

Image

@jsanz
Copy link
Member

jsanz commented Dec 17, 2024

Switch labels in the layer panel now feel a bit too big, but maybe just because the other labels are smaller now. Also in Lens I see smaller labels.

Screenshots
Borealis Amsterdam
Image Image

Lens borealis example

Image

Screenshots don't show this very well, and not feeling super strong about this in any case.

@tsullivan tsullivan added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Dec 17, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 17, 2024
@cqliu1 cqliu1 self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants