Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Prebuilt Rule Incorrectly Marked as Customized After Adding a Rule Exception #203011

Open
Tracked by #201502
pborgonovi opened this issue Dec 4, 2024 · 6 comments
Assignees
Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.17.1 v8.18.0 v9.0.0

Comments

@pborgonovi
Copy link
Contributor

Describe the bug:

Adding an exception to a prebuilt rule causes it to be incorrectly marked as “customized.”

Kibana/Elasticsearch Stack version:

8.x

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

Prebuilt Rules

Pre requisites:

  1. Feature flag prebuiltRulesCustomizationEnabled is enabled
  2. Prebuilt rules are installed

Steps to reproduce:

  1. Select a prebuilt rule
  2. Add a rule exception

Current behavior:

  • The prebuilt rule is marked as “Customized” after adding a rule exception.
  • The is_customized flag is set to true.

Expected behavior:

  • Adding a rule exception should not mark the prebuilt rule as customized.
  • The rule should remain marked as “Prebuilt” with is_customized set to false.
  • Rule exceptions should be managed independently without affecting the rule’s customization status.

Screenshots (if relevant):

Screen.Recording.2024-12-04.at.11.26.21.AM.mov
@pborgonovi pborgonovi added bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Dec 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror
Copy link
Contributor

@pborgonovi Thank you!

@dplumlee Could you please look into this? I'm not sure if it's the same as #201631 and #202575 or a different one.

@dplumlee
Copy link
Contributor

dplumlee commented Dec 5, 2024

@pborgonovi I'm not able to repro this on a fresh pull of main or 8.x using the same data you have in the attached video, can you validate?

@pborgonovi
Copy link
Contributor Author

Hey @dplumlee

As per what I've observed, this seems to be happening when an update is available for the rule. Take a look at this evidence:

Screen.Recording.2024-12-06.at.9.13.17.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

No branches or pull requests

4 participants