Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Check all spaces in getLogSourcesSettingDeprecationInfo #202649

Closed
afharo opened this issue Dec 3, 2024 · 2 comments · Fixed by #203042
Closed

[UA] Check all spaces in getLogSourcesSettingDeprecationInfo #202649

afharo opened this issue Dec 3, 2024 · 2 comments · Fixed by #203042
Assignees
Labels
Epic:Deprecations Deprecations Feature:Upgrade Assistant Team:obs-ux-logs Observability Logs User Experience Team

Comments

@afharo
Copy link
Member

afharo commented Dec 3, 2024

We noticed that getLogSourcesSettingDeprecationInfo only checks the configuration for the current space.

This can lead to users running Upgrade Assistant in one space, missing on deprecations occurring in other spaces.

The logic should make use of namespaces: ["*"] or namespaces: ['${spaceId}'] (while looping through all available spaces) to confirm that all spaces are compliant.

@afharo afharo added Epic:Deprecations Deprecations Feature:Upgrade Assistant Team:obs-ux-logs Observability Logs User Experience Team labels Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@rudolf
Copy link
Contributor

rudolf commented Dec 3, 2024

@Kerry350 identified some challenges in getting this deprecation working across spaces: #189646 (comment)

Notably how to write UiSettings of different spaces.

Core exposes asScopedToClient which could allow for creating a UiSettingsClient for each space where a deprecation was detected https://github.com/elastic/kibana/blob/main/packages/core/ui-settings/core-ui-settings-server/src/contracts.ts#L83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:Deprecations Deprecations Feature:Upgrade Assistant Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants