Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Connectors] message Missing required project id while running ... should only be logged for serverless #201045

Closed
pmuellr opened this issue Nov 20, 2024 · 3 comments
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Nov 20, 2024

I just happened to notice a log message running locally, that I think we should arrange to NOT log if not running on serverless:

[WARN ][plugins.actions] Missing required project id while running actions:connector_usage_reporting

It's generated here:

if (!this.projectId) {
this.logger.warn(
`Missing required project id while running ${CONNECTOR_USAGE_REPORTING_TASK_TYPE}`
);
return {
state,
};
}

Ideally, we wouldn't even schedule the task to run, if we're not on serverless, but I think the important part is not generating somewhat misleading log messages.

@pmuellr pmuellr added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ersin-erdal
Copy link
Contributor

There is already an open PR for this: #199650

It removes the task after the first run but there is already a discussion about not registering for non-serverless at all too.

@mikecote
Copy link
Contributor

Closing in favour of #199650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

4 participants