Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Kibana's status / error / loading pages to React / EUI #20016

Closed
3 tasks
snide opened this issue Jun 18, 2018 · 2 comments
Closed
3 tasks

Migrate Kibana's status / error / loading pages to React / EUI #20016

snide opened this issue Jun 18, 2018 · 2 comments
Labels
Meta stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@snide
Copy link
Contributor

snide commented Jun 18, 2018

The design team needs someone to convert the existing status / error / loading pages to React. We can help with the styling and usage of EUI components to make it look pretty, but everything should already be provided in EUI for that part.

Specifically with the loading page (the big circle) it would be nice to have some sort of string to designate the app/plugin that is loading. This way we can tailor the load a little different for each app.

cc @epixa

@snide snide added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 18, 2018
@epixa epixa added the Meta label Jun 19, 2018
@epixa
Copy link
Contributor

epixa commented Jun 19, 2018

I'm not sure if the loading page between apps can realistically use react for the legacy platform stuff (which is all current apps). The whole reason the loading page appears in the first place is that our bundles are large enough to take a non-trivial amount of time to load, so we show a loading indicator while the network requests are in flight to load the CSS/JS. We do this by coding all of the markup and styles for the loading indicator directly into the html payload and then removing them when the bundles finish loading.

This will be different in the new platform apps, where the loading indicator will happen within the context of the chrome rather than as a whole page refresh.

Either way, I do think we could inject the app name into the loading message, but I think we need a solution that can still be embedded entirely in the html payload.

@snide
Copy link
Contributor Author

snide commented Jun 19, 2018

That's fine. I'll style whatever you can give me.

@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants