Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard API][Meta] Cleanup dashboard typing #197529

Open
4 tasks
thomasneirynck opened this issue Oct 23, 2024 · 1 comment
Open
4 tasks

[Dashboard API][Meta] Cleanup dashboard typing #197529

thomasneirynck opened this issue Oct 23, 2024 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 23, 2024

Some of the API needs tweaking

  • object is now nested under item. Remove this nesting. (e.g. meta is SO-specific and should be removed) (perhaps this is needed for the RPC-layer of content-management which is used internally, but it shouldn't be)
  • namespaces should just be named spaces
  • kibanaSavedObjectMeta should be renamed to something generic (e.g. filterState, ...)
  • should we use snake case instead of camel case instead?
@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese changed the title [Dashboard][Meta] Cleanup dashboard typing [Dashboard API][Meta] Cleanup dashboard typing Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants