Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Datatable] Follow up on column actions after EUI 95 upgrade #193826

Open
dej611 opened this issue Sep 24, 2024 · 2 comments
Open

[Lens][Datatable] Follow up on column actions after EUI 95 upgrade #193826

dej611 opened this issue Sep 24, 2024 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Sep 24, 2024

From @cee-chen comment here:

Yep, I removed .euiDataGridHeader__action--selected from our classNames/CSS as it wasn't actually applying any useful styles anymore, and I hadn't realized this FTR test was hooking into it 😬 I replaced it instead with logic that adds "Sort/Unsort" text to represent currently sorted state:

eui-datatable
But it looks like the Lens datagrid completely overrides the sort label with your own Sort ascending/descending node, which means that the default "Unsort" text can't be hooked into.

Options I can look into:

Remove your label override with a schemaLabel instead, which means that you get EuiDataGrid's "Unsort" text (the schemaLabel replaces the A-Z/Z-A text only)
Re-add a selected state as a data- attribute of some kind that you can hook into (would likely be the next release, and I can revert the Lens changes at that point)

@dej611 dej611 added enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@cee-chen
Copy link
Contributor

It's still not clear to me what the ask is, but if y'all have one specifically please let me know if I can help.

To clarify also, these changes only applied to test utilities and not to source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants