Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Make timestamp.us optional and fall back to @timestamp #191046

Open
felixbarny opened this issue Aug 22, 2024 · 4 comments
Open

[APM] Make timestamp.us optional and fall back to @timestamp #191046

felixbarny opened this issue Aug 22, 2024 · 4 comments
Labels
apm:opentelemetry APM UI - OTEL Work apm blocked enhancement New value added to drive a business result OpenTelemetry Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@felixbarny
Copy link
Member

Today, the APM UI mostly relies on the timestamp.us field to place spans more accurately on the waterfall, and to support traces that take less than a millisecond.

We want to move the @timestamp field to use date_nanos instead of date, so that the additional timestamp.us field becomes redundant.

In the context of supporting OTel-native mappings, we'd like to transition to relying just on @timestamp but use the date_nanos field type for it. As a short-term workaround, we're adding attributes.timestamp.us but would like to remove this APM-specific field. During the transitioning period, we'll have a mix of date_nanos and @timestamp fields as we're waiting for ES|QL to support the date_nanos field type. While we'll likely also want to use date_nanos for data that goes in via APM Server, there's also expected to be a difference where OTel data will use date_nanos for the @timestamp field first.

I'm proposing the following fallback logic:

  • If timestamp.us is missing, fall back to @timestamp, no matter whether it's of type date or date_nanos
  • Optional: If @timestamp is of type date_nanos, prefer @timestamp over timestamp.us
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 22, 2024
@jughosta jughosta added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 2, 2024
@smith smith added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Sep 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rmyz
Copy link
Contributor

rmyz commented Sep 27, 2024

Blocking this as there are more priority items on the list, also, we have some discrepancies on how this should be tackled that need to be addressed #194100 (review)

@smith smith added the enhancement New value added to drive a business result label Oct 4, 2024
@rmyz
Copy link
Contributor

rmyz commented Jan 7, 2025

Closed PR #194100 as it has been stale for a while.

@rmyz rmyz removed their assignment Jan 11, 2025
@smith smith removed the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:opentelemetry APM UI - OTEL Work apm blocked enhancement New value added to drive a business result OpenTelemetry Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants