Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate styles from styled-components to emotion #190245

Open
2 of 5 tasks
maryam-saeidi opened this issue Aug 9, 2024 · 1 comment
Open
2 of 5 tasks

Migrate styles from styled-components to emotion #190245

maryam-saeidi opened this issue Aug 9, 2024 · 1 comment
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Aug 9, 2024

Summary

There is a plan to migrate from styled-components to emotion, and this ticket focuses on styled-components usages for obs-ux-management related plugins and related information for this migration. This migration helps to avoid issues related to sharing components with platform plugins, as they have already started this migration. (Avoiding issues such as #186969)

Here is a comment from EUI team about this migration.

Reference point for migration: #199715 (comment)

Here are hooks that can be used instead of styled-components ThemeContext: (comment)

Plugin Number of imports from styled-components Ticket
Observability 7
SLO 8 Fixed in #200247
Investigate 0 -
Investigate-app 0 -
Synthetics 16
Uptime 29

[For inspiration] Here are some PRs that tried to migrate some components :

@maryam-saeidi maryam-saeidi added the Team:obs-ux-management Observability Management User Experience Team label Aug 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

No branches or pull requests

2 participants