Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddable Rebuild] Add creation / configuration options to buildEmbeddable #189939

Closed
Heenawter opened this issue Aug 5, 2024 · 3 comments
Closed
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@Heenawter
Copy link
Contributor

Describe the feature:
Sometimes, when creating an embeddable, you need to pass in some state that is never modified after creation and does not need to be serialized. Examples include:

This state often controls how the embeddable is rendered initially, but is never used again - we should add a way to provide this state via the buildEmbeddable callback

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. project:embeddableRebuild labels Aug 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. technical debt Improvement of the software architecture and operational architecture and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 5, 2024
@ThomThomson
Copy link
Contributor

@Heenawter is this still needed you think? Or are the workarounds in place enough for now?

@Heenawter
Copy link
Contributor Author

@ThomThomson We can probably close this one for now - we're refactoring state a bunch in much more meaningful ways ATM.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants