Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM UI] Agent config settings should support 4 decimal places #183840

Closed
neptunian opened this issue May 20, 2024 · 1 comment · Fixed by #188555
Closed

[APM UI] Agent config settings should support 4 decimal places #183840

neptunian opened this issue May 20, 2024 · 1 comment · Fixed by #188555
Assignees
@jennypavlova
Labels
apm:Agent Configuration bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@neptunian
Copy link
Contributor

transaction_sample_rate for APM agents was changed to support 4 decimal places, up from 3, some time ago. The APM UI needs to be brought in alignment as it still only allows 3.

Issue tracking the change in agents
elastic/apm#335

Docs indicating 4 decimal places
https://github.com/elastic/apm/blob/main/specs/agents/tracing-sampling.md#transaction_sample_rate-configuration
https://www.elastic.co/guide/en/apm/agent/nodejs/current/configuration.html#transaction-sample-rate

Screenshot 2024-05-20 at 10 51 32 AM
@neptunian neptunian added the bug Fixes for quality problems that affect the customer experience label May 20, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label May 20, 2024
@neptunian neptunian added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label May 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 20, 2024
@jennypavlova jennypavlova self-assigned this Jul 16, 2024
@jennypavlova jennypavlova mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
apm:Agent Configuration bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Add four decimal places float validation for transaction_sample_rate jennypavlova/kibana
4 participants
@smith @neptunian @jennypavlova @elasticmachine