Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Logstash Pipelines #18065

Closed
elasticmachine opened this issue Oct 11, 2017 · 9 comments
Closed

[Accessibility] Logstash Pipelines #18065

elasticmachine opened this issue Oct 11, 2017 · 9 comments

Comments

@elasticmachine
Copy link
Contributor

Original comment by @aphelionz:

The entire pipeline UI, as it stands, is not accessible via keyboard (tab) navigation. Please see the following link for info about tabindex and SVG : LINK REDACTED

@ycombinator
Copy link
Contributor

ycombinator commented Aug 17, 2018

In 6.4.0 we are releasing a revamped Pipeline Viewer UI. IIRC, this new UI does not use SVG and, in fact, uses EUI components entirely. If so, then I believe this accessibility issue is now moot. @justinkambic can confirm this, perhaps after a bit of investigation into the code.

@justinkambic
Copy link
Contributor

Here's an example.. how does this look?
aug-21-2018 15-26-02

@ycombinator
Copy link
Contributor

Looks pretty good to me personally but I'm far from the expert on accessibility. Perhaps someone from the @elastic/kibana-design team could weigh in?

@snide
Copy link
Contributor

snide commented Aug 21, 2018

It seems OK. Generally for keyboard accessibility you need the think about the following.

  1. Tab order
  2. Focus states.

The later should be taken care of by EUI.

Beyond that, you're then getting into screen readers. Are you aria-labelling your buttons to say what they do... etc

I remember this stuff being pretty difficult to run locally, but if you need a refresher over zoom feel free to ping me.

@justinkambic
Copy link
Contributor

@snide I should be able to spin up a stack for you to point Kibana to like before if you wanted to test the accessibility. Aside from that, what's the best documentation to reference for this, so I can get to work and throw up a PR?

Thanks!

@snide
Copy link
Contributor

snide commented Aug 23, 2018

Hey, I'm getting to this way lay. If you wanna ping me on Slack we could probably go through it real quick over zoom.

@AlonaNadler
Copy link

Any news on this issue? is it still relevant in 6.4 and 6.5?

@justinkambic
Copy link
Contributor

@AlonaNadler I believe we are in good shape on this; I'll talk to @snide about it offline when he has availability just to be sure, and if there're any changes needed (which should be minor impact) I will put up a PR later this week, otherwise I'll write back here. Thanks!

@AlonaNadler
Copy link

Thanks for the update @justinkambic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants