Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Design improvements on the editor #180571

Closed
7 tasks
stratoula opened this issue Apr 11, 2024 · 2 comments
Closed
7 tasks

[ES|QL] Design improvements on the editor #180571

stratoula opened this issue Apr 11, 2024 · 2 comments
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@stratoula
Copy link
Contributor

stratoula commented Apr 11, 2024

Describe the feature:

General Experience

  • As they do not currently function as a mode toggle, there is no need to conditionally disable either of the pipe formatting buttons. Their current behavior is to apply the desired formatting once, but not enforce it thereafter. Unless we plan to change this behavior, I think they should always be enabled to avoid confusion.

    CleanShot 2024-04-05 at 15 21 59

Compact Experience

  • There appears to be some visual oddities around border radii for the interface when the editor is focused and showing historical queries (i.e. background colors from inner children covering corners, possibly because overflow isn't hidden). Would it be possible to fix these oddities?

    CleanShot 2024-04-05 at 15 00 31

  • The query editor body appears misaligned to the right by 1px, as it is colliding with the adjacent expand button.

    CleanShot 2024-04-05 at 15 01 30

  • The query editor's footer also appears misaligned to the right by 1px.

    CleanShot 2024-04-05 at 15 02 29

  • The "Last duration column" contents should be right aligned.

Expanded Experience

  • There appears to be a 2px border between editor header and body. This should be 1px.

    CleanShot 2024-04-05 at 15 17 34

  • Focusing the editor body causes the entire editor interface to increase in height by 1px, causing all content below it visibly jump 1px. I'm guessing this is due to the appearance of the 2px blue border on focus. Would it be possible to fix it so this jump doesn't happen?

    CleanShot 2024-04-05 at 15 18 44

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Apr 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Apr 11, 2024
@stratoula
Copy link
Contributor Author

This is not valid anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

No branches or pull requests

2 participants