Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables Rebuild] Remove legacy embeddable migrations in 9.x #180060

Open
Tracked by #167429
ThomThomson opened this issue Apr 4, 2024 · 1 comment
Open
Tracked by #167429

[Embeddables Rebuild] Remove legacy embeddable migrations in 9.x #180060

ThomThomson opened this issue Apr 4, 2024 · 1 comment
Labels
blocked Feature:Embeddables Relating to the Embeddable system impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Apr 4, 2024 •
edited by nreese
Loading

Problem

Blocked on #180058

The legacy embeddable framework has a serverside embeddable migrations system that is meant to migrate by value Embeddables saved in Dashboards to their latest values. This comes with an entire serverside embeddable factory registry.

Unfortunately, this code cannot be removed as part of #180058 because that would destroy the ability to upgrade from versions below 8.13 to the last minor in the 8.x series. In our next major version, 9.x, these migrations will no longer be needed, which means they should be removed.
@ThomThomson ThomThomson added blocked Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Embeddables Relating to the Embeddable system labels Apr 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Apr 4, 2024
Open
@nreese nreese changed the title [Embeddables Rebuild] Remove legacy embeddable migrations in 9.0 [Embeddables Rebuild] Remove legacy embeddable migrations in 9.x Jan 15, 2025
@nreese nreese added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Feature:Embeddables Relating to the Embeddable system impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @Heenawter @ThomThomson @elasticmachine