Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Use EUI Toasts for error and info messages #17961

Closed
elasticmachine opened this issue Mar 22, 2017 · 4 comments
Closed

[ML] Use EUI Toasts for error and info messages #17961

elasticmachine opened this issue Mar 22, 2017 · 4 comments

Comments

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 22, 2017

Some of the pages in the ML plugin, such as the jobs list and creation pages, have their own message bar for displaying error and information messages - public/components/messagebar/messagebar_service.js. This should be replaced with EUI's toast notification system.

However in order to use the EUI Toasts, they need to allow for the expansion of server error messages in the UI (if a response is supplied), for example:

image

screen shot 2018-07-16 at 12 39 10

Currently there is no way to handle 'show more' information in a toast, and the EUI toast needs to be able to handle large stack trace information, which would currently overflow in the limited width that the toast currently allows.

One consideration is the use of error messages when displaying form mistakes for new jobs.
For example, if the user forgets to enter a job name, we currently display a error in the message bar and a local context specific message. Error messages should be automatically cleared once the user corrects the mistake and attempts another save.

Note the old Notifier system is currently used in:

  • x-pack/plugins/ml/public/components/full_time_range_selector/full_time_range_selector_service.js
@elasticmachine
Copy link
Contributor Author

Original comment by @sophiec20:

Relates LINK REDACTED

@peteharverson peteharverson changed the title [ML] Use Kibana's Notifier for job error and info messages [ML] Use EUI Toasts for error and info messages Feb 26, 2019
@peteharverson
Copy link
Contributor

See related meta issue #31943

@jgowdyelastic
Copy link
Member

also related #20880

@timroes
Copy link
Contributor

timroes commented Jul 22, 2019

This has now all been done via #41191 lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants