Graph UI needs zoom controls

[elasticmachine]

Original comment by @peterskim12:

Maybe I'm a weirdo but I disable zoom functions (along with pretty much all other functions) on my MacBook Pro trackpad to prevent inadvertent actions. I can't find a way to zoom in and out in the Graph UI if I don't use the trackpad.

There should be controls in the Graph UI to zoom in and out similar to Google Maps:

!LINK REDACTED

[elasticmachine]

Original comment by @markharwood:

The current trackpad behaviour (at least on my mac) is that a 2 finger swipe up or down will zoom. This is consistent with Google maps behaviour.

I disable zoom functions
I see there is an OSX System preference that disables the zoom action but that is tied to the pinch action not the 2 finger vertical swipe?

Presumably you have 2 finger vertical swipes enabled in order to scroll pages?

The disadvantage with using buttons for zoom is that action is normally targeted on the screen centre and a mouse/trackpad based zoom is more naturally associated with centring on the current location of the mouse. If we add the buttons people may fall into the trap of using them and then they have to pan a lot more to arrive at their area of interest. Maybe some help text describing the current mouse/trackpad targeted zoom behaviour is required?

[elasticmachine]

Original comment by @peterskim12:

I've disabled all trackpad gestures intentionally, except for the 2 finger scroll.
Also anyone using a traditional mouse or trackball have no way to zoom in and out.

[elasticmachine]

Original comment by @markharwood:

I've disabled all trackpad gestures intentionally, except for the 2 finger scroll.

2 finger scroll is the zoom gesture.

Also anyone using a traditional mouse or trackball have no way to zoom in and out.

Granted, anyone without a mouse scroller wheel will be stuck so buttons make sense.

[elasticmachine]

Original comment by @peterskim12:

Ok cool, I didn't realize the 2 finger scroll does zoom also. I assumed the "Pinch with two fingers" was required to zoom.

Yeah I think it's still important to make sure this UI is usable by people who have a traditional 2 button mouse or other input devices that doesn't have a scroll function. At home, I use a Windows 10 Desktop with a Logitech trackball; there's a way to configure it to do scroll but I don't have it set up that way.

[elasticmachine]

Original comment by @markharwood:

I hoped this would be a quick fix I could turn around but isn't as easy as I thought.
Zoom-scale and pan position is held as state inside d3 somewhere and updated with mouse scroll actions and passed out on event objects. If we have custom buttons outside of d3 that change zoom and pan position on the SVG DOM elements I need to find a way to also reset the d3-managed scale and pan variables otherwise mouse actions and button actions are incrementing two different notions of the current zoom and pan levels. Things leap around unexpectedly flipping between mouse and buttons with my first simplistic attempt at this.
Also, the pointer-less style of zooming using buttons cannot just increment and decrement scale - it must also adjust pan appropriately each time to remain centred. Need to figure out that logic too.

So parking this one currently due to the priorities of other work.

[elasticmachine]

Original comment by @peterskim12:

Cool thanks for making the effort @markharwood.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

[timductive]

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.