Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Write tests for SLO alerts table embeddable #175228

Closed
Tracked by #182636
mgiota opened this issue Jan 22, 2024 · 1 comment
Closed
Tracked by #182636

[SLO] Write tests for SLO alerts table embeddable #175228

mgiota opened this issue Jan 22, 2024 · 1 comment
Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@mgiota
Copy link
Contributor

mgiota commented Jan 22, 2024 •
edited
Loading

Part of #182636

🍒 Summary

This PR fixes a bug in the SLO alerts table embeddable, where the flyout wouldn't open when clicking on the reason column. This bug was introduced with this PR. Since SLO alerts table embeddable uses a shared component, we should make sure there are tests that will catch any changes in the Shared alerts table.

✔️ Acceptance criteria

Write tests for the SLO alerts table embeddable.
@mgiota mgiota self-assigned this Jan 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 22, 2024
@mgiota mgiota mentioned this issue Jan 22, 2024
Merged
3 tasks
@mgiota mgiota added the Team:obs-ux-management Observability Management User Experience Team label Jan 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 22, 2024
@mgiota mgiota mentioned this issue May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kdelemme @mgiota @elasticmachine